Conversation
| arg_type = f"{instruction_utils.data_type_map[arg.ty.ty.kind]}* " | ||
| arg_size = actual_size(arg.ty.ty.size) | ||
| full_type = f"{arg_type}{arg_size}*" | ||
| if arg.ty.ty.kind == type_info.TypeKind.VOID: |
There was a problem hiding this comment.
The case might not be necessary or is something not working here? The map has also the VOID case in there:
There was a problem hiding this comment.
@jokap11 but void pointers have a size=None which breaks arg_size = actual_size(arg.ty.ty.size).
But you are correct that I could still use data_type_map. Let me know if I should change it.
There was a problem hiding this comment.
Does not really matter anyways, but thanks for the explanation. LGTM now!
|
One notated thing. Rest looks nice. Maybe update also this here? Line 25 in 636a6dd I am probably the only user anyways, so skip if too much effort ;) |
i don’t want to update the launch.json without testing it, hence I will merge without a change. Feel free to follow up later. |
2 participants
No description provided.